Notify user of unsaved edits #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… navigating away from text editor pages
…tor to assist with deserialization
egbicker
changed the title
|
Config dialog has rule text
|
jw3
changed the title
This was referenced Oct 31, 2023
jw3
added a commit
that referenced
this pull request
Oct 31, 2023
This fixes an issue where the text editors were erroneously notifying of existing changes after a deployment. For reference see the changes in #727 and #921. The text clearing in the former is clashing with the flagging in the latter. This PR addressed it by flipping a flag right after the point where the text is cleared. Closes #934
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notify user of unsaved text when navigating away from editor.
The user can decide whether to remain on the page, or discard unsaved changes to navigate away.
Closes #912