Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version information #116

Merged
merged 6 commits into from
Dec 30, 2021
Merged

add version information #116

merged 6 commits into from
Dec 30, 2021

Conversation

scholarsmate
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021

Codecov Report

Merging #116 (a3317a5) into main (9bb23c8) will increase coverage by 0.05%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   93.98%   94.03%   +0.05%     
==========================================
  Files          16       17       +1     
  Lines        1113     1124      +11     
==========================================
+ Hits         1046     1057      +11     
  Misses         67       67              
Impacted Files Coverage Δ
src/lib/impl_/internal_fun.cpp 62.29% <40.00%> (ø)
src/include/omega_edit/stl_string_adaptor.hpp 100.00% <100.00%> (ø)
src/lib/version.c 100.00% <100.00%> (ø)
src/tests/omega_test.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb23c8...a3317a5. Read the comment docs.

@scholarsmate
Copy link
Member Author

Added version information programmatically to the library using CMake. The version code is generated into the build tree. The bindings created by node-gyp are not aware of the CMake build tree, so the bindings currently do not have access to the generated source.

@scholarsmate scholarsmate linked an issue Dec 30, 2021 that may be closed by this pull request
@scholarsmate scholarsmate merged commit fb0de22 into main Dec 30, 2021
@scholarsmate scholarsmate deleted the version_info branch December 30, 2021 23:03
@scholarsmate scholarsmate self-assigned this Jan 6, 2022
@scholarsmate scholarsmate added this to the v0.7.0 milestone Jan 6, 2022
@scholarsmate scholarsmate added the documentation Improvements or additions to documentation label Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

Add version information
2 participants