Pr25 fix intermittent non zero return code #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`head` occasionally closes the pipe before `vim --version` finishes writing to it, causing the command to fail with return code 141 (exit due to SIGPIPE). An explicit `test` for code 141 ignores that without squashing other errors.
Fix intermittent non-zero return code
- @see stefangweichinger/ansible-rclone#105 - Re: pr25-fix-intermittent-non-zero-return-code
|
The tests actually run now. H/t to @robertdebock and @stefangweichinger for their work in stefangweichinger/ansible-rclone#105. Not all of them pass, but that's on me :) |
… in CI - Re: pr25-fix-intermittent-non-zero-return-code
- Re: pr25-fix-intermittent-non-zero-return-code
- Re: pr25-fix-intermittent-non-zero-return-code
- Re: pr25-fix-intermittent-non-zero-return-code
- Re: pr25-fix-intermittent-non-zero-return-code
- Since the last release, we've been handling all file operations *as* a certain user, so we can rely on that to ensure the group and mode are set in line with the system's configuration. - We're still testing for group since (in the context of the tests) a group that is NOT identical to vim_owner is a sign that something's gone wrong with some task's become and become_user settings. - Re: pr25-fix-intermittent-non-zero-return-code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes fies for intermittend non-zero return code, hopefully fixes tests.