Skip to content

Commit

Permalink
fix: remove key collision logging
Browse files Browse the repository at this point in the history
While this log message is nice to have, it's not worth having an
infinite loop over

Alternative solutions:
- Consider renaming colliding field

Fixes LukeMathWalker#33
  • Loading branch information
ctrlaltf24 committed Jul 14, 2023
1 parent c506eaf commit 499c2f5
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions src/formatting_layer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,10 @@ impl<W: for<'a> MakeWriter<'a> + 'static> BunyanFormattingLayer<W> {
if !BUNYAN_REQUIRED_FIELDS.contains(&key.as_str()) {
self.serialize_field(&mut map_serializer, key, value)?;
} else {
tracing::debug!(
"{} is a reserved field in the bunyan log format. Skipping it.",
key
);
// tracing::debug!(
// "{} is a reserved field in the bunyan log format. Skipping it.",
// key
// );
}
}

Expand All @@ -225,10 +225,10 @@ impl<W: for<'a> MakeWriter<'a> + 'static> BunyanFormattingLayer<W> {
if !BUNYAN_REQUIRED_FIELDS.contains(key) {
self.serialize_field(&mut map_serializer, key, value)?;
} else {
tracing::debug!(
"{} is a reserved field in the bunyan log format. Skipping it.",
key
);
// tracing::debug!(
// "{} is a reserved field in the bunyan log format. Skipping it.",
// key
// );
}
}
}
Expand Down Expand Up @@ -364,10 +364,10 @@ where
if !BUNYAN_REQUIRED_FIELDS.contains(key) {
self.serialize_field(&mut map_serializer, key, value)?;
} else {
tracing::debug!(
"{} is a reserved field in the bunyan log format. Skipping it.",
key
);
// tracing::debug!(
// "{} is a reserved field in the bunyan log format. Skipping it.",
// key
// );
}
}
}
Expand Down

0 comments on commit 499c2f5

Please sign in to comment.