Skip to content

Commit 001ddc8

Browse files
robclarkRob Clark
authored andcommitted
drm/msm: Don't close VMAs on purge
Previously we'd also tear down the VMA, making the address space available again. But with drm_gpuvm conversion, this would require holding the locks of all VMs the GEM object is mapped in. Which is problematic for the shrinker. Instead just let the VMA hang around until the GEM object is freed. Signed-off-by: Rob Clark <robdclark@chromium.org> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com> Tested-by: Antonino Maniscalco <antomani103@gmail.com> Reviewed-by: Antonino Maniscalco <antomani103@gmail.com> Patchwork: https://patchwork.freedesktop.org/patch/661472/
1 parent b5e7a2f commit 001ddc8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/msm/msm_gem.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -755,7 +755,7 @@ void msm_gem_purge(struct drm_gem_object *obj)
755755
GEM_WARN_ON(!is_purgeable(msm_obj));
756756

757757
/* Get rid of any iommu mapping(s): */
758-
put_iova_spaces(obj, true);
758+
put_iova_spaces(obj, false);
759759

760760
msm_gem_vunmap(obj);
761761

0 commit comments

Comments
 (0)