Skip to content

Commit 14ce2c2

Browse files
tititiou36martinkpetersen
authored andcommitted
scsi: fnic: Use vzalloc()
Use vzalloc() instead of hand writing it with vmalloc()+memset(). This is less verbose. This also fixes some style issues :) Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/a1179941a6d440140513e681f4f3a1b92c8d83ae.1685210773.git.christophe.jaillet@wanadoo.fr Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 4851c39 commit 14ce2c2

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

drivers/scsi/fnic/fnic_debugfs.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -201,25 +201,21 @@ static int fnic_trace_debugfs_open(struct inode *inode,
201201
return -ENOMEM;
202202

203203
if (*rdata_ptr == fc_trc_flag->fnic_trace) {
204-
fnic_dbg_prt->buffer = vmalloc(array3_size(3, trace_max_pages,
204+
fnic_dbg_prt->buffer = vzalloc(array3_size(3, trace_max_pages,
205205
PAGE_SIZE));
206206
if (!fnic_dbg_prt->buffer) {
207207
kfree(fnic_dbg_prt);
208208
return -ENOMEM;
209209
}
210-
memset((void *)fnic_dbg_prt->buffer, 0,
211-
3 * (trace_max_pages * PAGE_SIZE));
212210
fnic_dbg_prt->buffer_len = fnic_get_trace_data(fnic_dbg_prt);
213211
} else {
214212
fnic_dbg_prt->buffer =
215-
vmalloc(array3_size(3, fnic_fc_trace_max_pages,
213+
vzalloc(array3_size(3, fnic_fc_trace_max_pages,
216214
PAGE_SIZE));
217215
if (!fnic_dbg_prt->buffer) {
218216
kfree(fnic_dbg_prt);
219217
return -ENOMEM;
220218
}
221-
memset((void *)fnic_dbg_prt->buffer, 0,
222-
3 * (fnic_fc_trace_max_pages * PAGE_SIZE));
223219
fnic_dbg_prt->buffer_len =
224220
fnic_fc_trace_get_data(fnic_dbg_prt, *rdata_ptr);
225221
}

0 commit comments

Comments
 (0)