scsi: fnic: Remove redundant NULL check

Lotte-Bai · martinkpetersen · commit 1dcd96c4d0b7 · 2022-04-25T23:23:05.000-04:00
Fix the following warning reported by coccicheck: drivers/scsi/fnic/fnic_debugfs.c:90:2-7: WARNING: NULL check before some freeing functions is not needed. Link: https://lore.kernel.org/r/1647309219-12772-1-git-send-email-baihaowen@meizu.com Signed-off-by: Haowen Bai <baihaowen@meizu.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c
@@ -86,8 +86,7 @@ void fnic_debugfs_terminate(void)
 	debugfs_remove(fnic_trace_debugfs_root);
 	fnic_trace_debugfs_root = NULL;
 
-	if (fc_trc_flag)
-		vfree(fc_trc_flag);
+	vfree(fc_trc_flag);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,7 @@ void fnic_debugfs_terminate(void)`
`86`	`86`	`debugfs_remove(fnic_trace_debugfs_root);`
`87`	`87`	`fnic_trace_debugfs_root = NULL;`
`88`	`88`
`89`		`- if (fc_trc_flag)`
`90`		`- vfree(fc_trc_flag);`
	`89`	`+ vfree(fc_trc_flag);`
`91`	`90`	`}`
`92`	`91`
`93`	`92`	`/*`