scsi: fnic: remove redundant assignment of variable rc

Colin Ian King · martinkpetersen · commit 9730ddfb123d · 2019-08-19T21:51:00.000-04:00
Variable ret is initialized to a value that is never read and it is
re-assigned later and immediately returns. Clean up the code by removing
rc and just returning 0.

[mkp: typo]

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Acked-by: Karan Tilak Kumar &lt;kartilak@cisco.com&gt;
Signed-off-by: Martin K. Petersen &lt;martin.petersen@oracle.com&gt;
diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c
@@ -52,7 +52,6 @@ static struct fc_trace_flag_type *fc_trc_flag;
  */
 int fnic_debugfs_init(void)
 {
-	int rc = -1;
 	fnic_trace_debugfs_root = debugfs_create_dir("fnic", NULL);
 
 	fnic_stats_debugfs_root = debugfs_create_dir("statistics",
@@ -70,8 +69,7 @@ int fnic_debugfs_init(void)
 		fc_trc_flag->fc_clear = 4;
 	}
 
-	rc = 0;
-	return rc;
+	return 0;
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,6 @@ static struct fc_trace_flag_type *fc_trc_flag;`
`52`	`52`	`*/`
`53`	`53`	`int fnic_debugfs_init(void)`
`54`	`54`	`{`
`55`		`- int rc = -1;`
`56`	`55`	`fnic_trace_debugfs_root = debugfs_create_dir("fnic", NULL);`
`57`	`56`
`58`	`57`	`fnic_stats_debugfs_root = debugfs_create_dir("statistics",`
`@@ -70,8 +69,7 @@ int fnic_debugfs_init(void)`
`70`	`69`	`fc_trc_flag->fc_clear = 4;`
`71`	`70`	`}`
`72`	`71`
`73`		`- rc = 0;`
`74`		`- return rc;`
	`72`	`+ return 0;`
`75`	`73`	`}`
`76`	`74`
`77`	`75`	`/*`