Skip to content

Commit c0eb059

Browse files
krzkAngeloGioacchino Del Regno
authored andcommitted
soc: mediatek: mtk-devapc: Fix leaking IO map on error paths
Error paths of mtk_devapc_probe() should unmap the memory. Reported by Smatch: drivers/soc/mediatek/mtk-devapc.c:292 mtk_devapc_probe() warn: 'ctx->infra_base' from of_iomap() not released on lines: 277,281,286. Fixes: 0890beb ("soc: mediatek: add mt6779 devapc driver") Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20250104142012.115974-1-krzysztof.kozlowski@linaro.org Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
1 parent 40384c8 commit c0eb059

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

drivers/soc/mediatek/mtk-devapc.c

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -273,23 +273,31 @@ static int mtk_devapc_probe(struct platform_device *pdev)
273273
return -EINVAL;
274274

275275
devapc_irq = irq_of_parse_and_map(node, 0);
276-
if (!devapc_irq)
277-
return -EINVAL;
276+
if (!devapc_irq) {
277+
ret = -EINVAL;
278+
goto err;
279+
}
278280

279281
ctx->infra_clk = devm_clk_get_enabled(&pdev->dev, "devapc-infra-clock");
280-
if (IS_ERR(ctx->infra_clk))
281-
return -EINVAL;
282+
if (IS_ERR(ctx->infra_clk)) {
283+
ret = -EINVAL;
284+
goto err;
285+
}
282286

283287
ret = devm_request_irq(&pdev->dev, devapc_irq, devapc_violation_irq,
284288
IRQF_TRIGGER_NONE, "devapc", ctx);
285289
if (ret)
286-
return ret;
290+
goto err;
287291

288292
platform_set_drvdata(pdev, ctx);
289293

290294
start_devapc(ctx);
291295

292296
return 0;
297+
298+
err:
299+
iounmap(ctx->infra_base);
300+
return ret;
293301
}
294302

295303
static void mtk_devapc_remove(struct platform_device *pdev)

0 commit comments

Comments
 (0)