Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for onSize not rendering children (Issue: #136) #138

Merged
merged 1 commit into from
May 2, 2018

Conversation

hdwatts
Copy link
Contributor

@hdwatts hdwatts commented Apr 24, 2018

Previously setState was not being called if the 'strategy' was a callback, causing the child components to not get rendered.

This fixes issue #136 for me

@codecov
Copy link

codecov bot commented Apr 24, 2018

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files           3        3           
  Lines          86       86           
  Branches       23       23           
=======================================
  Hits           76       76           
  Misses          8        8           
  Partials        2        2
Impacted Files Coverage Δ
src/sizeMe.js 95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 871c3ea...da1ad8e. Read the comment docs.

@ctrlplusb
Copy link
Owner

Legend, thanks 👍

@ctrlplusb ctrlplusb merged commit c04e6f3 into ctrlplusb:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants