Skip to content
This repository has been archived by the owner on Jun 3, 2019. It is now read-only.

Feature/redux opinionated #338

Conversation

maximblack
Copy link

No description provided.

# Conflicts:
#	config/internals/environmentVars.js
#	config/private/project.js
#	package.json
#	src/server/middleware/reactApplication/index.js
# Conflicts:
#	package.json
#	src/server/middleware/reactApplication/index.js
#	yarn.lock
# Conflicts:
#	package.json
#	yarn.lock
…-opinionated

# Conflicts:
#	config/index.js
#	package.json
#	src/client/index.js
#	src/server/middleware/reactApplication/index.js
#	yarn.lock
@kikoanis
Copy link

@maximblack Thanks for the pull. very helpful.

One issue though. Not sure what I am doing wrong but this pull as well as the previous intl branch does not work for me when trying to serve offline.

I noticed this only happens if I use react-intl library. probably it is related to code-split-component. Tried many solutions. The original redux-oponianated works fine.

Any idea what I am doing wrong?

@montezume
Copy link

Hi,

I'm not sure if this is a stupid question or not, but would it make sense to use polyfill.io for the polyfilling instead of dealing with all of this complexity?

@ctrlplusb
Copy link
Owner

Hey all; given our decision to reduce the feature branches I am going to close this for now. Please feel free to maintain any forks off site. I am happy to add them to our README, however, I'd like to keep this repo a bit more streamlined and maintainable.

Thanks! 💖

@ctrlplusb ctrlplusb closed this Apr 4, 2017
@oyeanuj oyeanuj mentioned this pull request Oct 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants