This repository has been archived by the owner on Jun 22, 2019. It is now read-only.
Merge People Search and Suggestions #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 19, 2016 12:46
…whether the search controller is active.
… display type is Users
… the UsersViewController
…elf.user was used to determine follow label text.
|
Going to keep this open until we have the backend changes. @mrkbryn please update me when the changes are in. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11 to merge suggestions into the users view controller to consolidate suggestions and people searches into one location. When search bar is not active, the users view controller acts as a suggestions VC. When it becomes active, allows a user to search the user database. Followers and Following display types for UsersVC operate as before, but each cell gains a follow button so a user can follow and unfollow users anywhere a UsersVC is presented.
I'm currently waiting on backend to implement is_following flag, which will allow my feature to work. I was unable to test the final branch because of this, but it should work once this is implemented on the backend.
Also, I chose not to delete the FollowSuggestionsTableViewController and the FollowSuggestionCell files in case we need these later (even though there are not used anywhere in my new feature branch). However, I can delete these if it helps keep the project readable and uncluttered.