fix(@cubejs-backend/elasticsearch-driver): respect ungrouped parameter (#684) Thanks to @gauravlanjekar!

gauravlanjekar · glanjekar · web-flow · commit 27d0d49b780c · 2020-06-03T09:48:16.000-07:00
Co-authored-by: gaurav lanjekar &lt;gaurav@leanspace.io&gt;
diff --git a/packages/cubejs-schema-compiler/adapter/AWSElasticSearchQuery.js b/packages/cubejs-schema-compiler/adapter/AWSElasticSearchQuery.js
@@ -51,6 +51,9 @@ class AWSElasticSearchQuery extends BaseQuery {
   }
 
   groupByClause() {
+    if (this.ungrouped) {
+      return '';
+    }
     const dimensionsForSelect = this.dimensionsForSelect();
     const dimensionColumns = R.flatten(dimensionsForSelect.map(s => s.selectColumns() && s.dimensionSql()))
       .filter(s => !!s);

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,9 @@ class AWSElasticSearchQuery extends BaseQuery {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`groupByClause() {`
	`54`	`+ if (this.ungrouped) {`
	`55`	`+ return '';`
	`56`	`+ }`
`54`	`57`	`const dimensionsForSelect = this.dimensionsForSelect();`
`55`	`58`	`const dimensionColumns = R.flatten(dimensionsForSelect.map(s => s.selectColumns() && s.dimensionSql()))`
`56`	`59`	`.filter(s => !!s);`