fix: Orphaned pre-aggregation tables aren't dropped because LocalCacheDriver doesn't expire keys

paveltiunov · paveltiunov · commit 393af3dc7659 · 2020-03-18T14:58:50.000-07:00
diff --git a/packages/cubejs-query-orchestrator/orchestrator/LocalCacheDriver.js b/packages/cubejs-query-orchestrator/orchestrator/LocalCacheDriver.js
@@ -24,7 +24,8 @@ class LocalCacheDriver {
   }
 
   async keysStartingWith(prefix) {
-    return Object.keys(this.store).filter(k => k.indexOf(prefix) === 0);
+    return Object.keys(this.store)
+      .filter(k => k.indexOf(prefix) === 0 && this.store[k].exp > new Date().getTime());
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,8 @@ class LocalCacheDriver {`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`async keysStartingWith(prefix) {`
`27`		`- return Object.keys(this.store).filter(k => k.indexOf(prefix) === 0);`
	`27`	`+ return Object.keys(this.store)`
	`28`	`+ .filter(k => k.indexOf(prefix) === 0 && this.store[k].exp > new Date().getTime());`
`28`	`29`	`}`
`29`	`30`	`}`
`30`	`31`