fix: TypeError: (queryOptions.dialectClass || ADAPTERS[dbType]) is not a constructor

Author: paveltiunov

packages/cubejs-server-core/core/CompilerApi.js

@@ -55,10 +55,9 @@ class CompilerApi {
   async getSql(query, options) {
     options = options || {};
     const { includeDebugInfo } = options;
-    const dbType = this.getDbType('default');
-    const dialectClass = this.getDialectClass('default');
+    const dbType = this.getDbType();
     const compilers = await this.getCompilers({ requestId: query.requestId });
-    let sqlGenerator = this.createQuery(compilers, dbType, dialectClass, query);
+    let sqlGenerator = this.createQueryByDataSource(compilers, query);
     if (!sqlGenerator) {
       throw new Error(`Unknown dbType: ${dbType}`);
     }
@@ -67,11 +66,10 @@ class CompilerApi {
 
     if (dataSource !== 'default' && dbType !== this.getDbType(dataSource)) {
       // TODO consider more efficient way than instantiating query
-      sqlGenerator = this.createQuery(
+      sqlGenerator = this.createQueryByDataSource(
         compilers,
-        this.getDbType(dataSource),
-        this.getDialectClass(dataSource),
-        query
+        query,
+        dataSource
       );
     }
 
@@ -96,6 +94,10 @@ class CompilerApi {
     return cubeEvaluator.scheduledPreAggregations();
   }
 
+  createQueryByDataSource(compilers, query, dataSource) {
+    return this.createQuery(compilers, this.getDbType(dataSource), this.getDialectClass(dataSource), query);
+  }
+
   createQuery(compilers, dbType, dialectClass, query) {
     return QueryBuilder.query(
       compilers,

packages/cubejs-server-core/core/RefreshScheduler.js

@@ -6,9 +6,8 @@ class RefreshScheduler {
   }
 
   async refreshQueriesForPreAggregation(context, compilerApi, preAggregation, queryingOptions) {
-    const dbType = compilerApi.getDbType();
     const compilers = await compilerApi.getCompilers();
-    const query = compilerApi.createQuery(compilers, dbType, queryingOptions);
+    const query = compilerApi.createQueryByDataSource(compilers, queryingOptions);
     if (preAggregation.preAggregation.partitionGranularity) {
       const dataSource = query.cubeDataSource(preAggregation.cube);
 
@@ -45,7 +44,7 @@ class RefreshScheduler {
           dateRange
         }]
       };
-      const partitionQuery = compilerApi.createQuery(compilers, dbType, baseQuery);
+      const partitionQuery = compilerApi.createQueryByDataSource(compilers, baseQuery);
       const { partitionDimension } = partitionQuery.preAggregations.partitionDimension(preAggregation);
       return partitionDimension.timeSeries().map(range => ({
         ...baseQuery,
@@ -116,9 +115,8 @@ class RefreshScheduler {
   }
 
   async refreshCubesRefreshKey(context, compilerApi, queryingOptions) {
-    const dbType = compilerApi.getDbType();
     const compilers = await compilerApi.getCompilers();
-    const queryForEvaluation = compilerApi.createQuery(compilers, dbType, {});
+    const queryForEvaluation = compilerApi.createQueryByDataSource(compilers, {});
     await Promise.all(queryForEvaluation.cubeEvaluator.cubeNamesWithRefreshKeys().map(async cube => {
       const cubeFromPath = queryForEvaluation.cubeEvaluator.cubeFromPath(cube);
       const measuresCount = Object.keys(cubeFromPath.measures || {}).length;