fix: Allow empty complex boolean filter arrays (#1100)

* Bugfix: allow filters without arguments.

* code style

* remove 1=1 from result sql query

Author: VictorTrapenok

packages/cubejs-schema-compiler/adapter/BaseGroupFilter.js

@@ -1,3 +1,5 @@
+const R = require('ramda');
+
 class BaseGroupFilter {
   constructor(query, filter) {
     this.values = filter.values;
@@ -7,7 +9,18 @@ class BaseGroupFilter {
   }
 
   filterToWhere() {
-    return this.values.map(f => `(${f.filterToWhere()})`).join(` ${this.operator} `);
+    const r = this.values.map(f => {
+      const sql = f.filterToWhere();
+      if (!sql) {
+        return null;
+      }
+      return `(${sql})`;
+    }).filter(R.identity).join(` ${this.operator} `);
+    
+    if (!r.length) {
+      return null;
+    }
+    return r;
   }
 
   getMembers() {

packages/cubejs-schema-compiler/adapter/BaseQuery.js

@@ -102,6 +102,14 @@ class BaseQuery {
             measure: measure[0],
           };
         }
+        if (!dimension.length && !measure.length) {
+          return {
+            values: [],
+            operator,
+            dimension: null,
+            measure: null,
+          };
+        }
         throw new UserError(`You cannot use dimension and measure in same condition: ${JSON.stringify(f)}`);
       }
 

packages/cubejs-schema-compiler/test/SQLGenerationLogicTest.js

@@ -768,6 +768,97 @@ describe('SQL Generation', function test() {
     });
   }));
 
+  it('where filter without arguments', () => compiler.compile().then(() => {
+    const query = new PostgresQuery({ joinGraph, cubeEvaluator, compiler }, {
+      measures: [
+        'visitors.visitor_count'
+      ],
+      dimensions: [
+        'visitors.source',
+      ],
+      timeDimensions: [],
+      timezone: 'America/Los_Angeles',
+      filters: [
+        {
+          and: [
+            {
+              and: [
+                {
+                  or: [
+                    {
+                      and: [
+                        {
+                          member: 'visitors.source',
+                          operator: 'equals',
+                          values: ['some']
+                        }
+                      ]
+                    },
+                    {
+                      and: []
+                    }
+                  ]
+                }]
+            }]
+        }],
+      order: [{
+        'visitors.visitor_count': 'desc'
+      }]
+    });
+
+    console.log(query.buildSqlAndParams());
+
+    return dbRunner.testQuery(query.buildSqlAndParams()).then(res => {
+      console.log(JSON.stringify(res));
+      res.should.be.deepEqual([{ 'visitors__source': 'some', 'visitors__visitor_count': '2' }]);
+    });
+  }));
+
+  it('where filter without any arguments', () => compiler.compile().then(() => {
+    const query = new PostgresQuery({ joinGraph, cubeEvaluator, compiler }, {
+      measures: [
+        'visitors.visitor_count'
+      ],
+      dimensions: [
+        'visitors.source',
+      ],
+      timeDimensions: [],
+      timezone: 'America/Los_Angeles',
+      filters: [
+        {
+          and: [
+            {
+              and: [
+                {
+                  or: [
+                    {
+                      and: []
+                    },
+                    {
+                      and: []
+                    }
+                  ]
+                }]
+            }]
+        }],
+      order: [{
+        'visitors.visitor_count': 'desc'
+      }]
+    });
+
+    console.log(query.buildSqlAndParams());
+
+    return dbRunner.testQuery(query.buildSqlAndParams()).then(res => {
+      console.log(JSON.stringify(res));
+      res.should.be.deepEqual(
+        [
+          { 'visitors__source': null, 'visitors__visitor_count': '3' },
+          { 'visitors__source': 'google', 'visitors__visitor_count': '1' },
+          { 'visitors__source': 'some', 'visitors__visitor_count': '2' }
+        ]
+      );
+    });
+  }));
   it('where filter with incorrect one arguments', () => compiler.compile().then(() => {
     try {
       const query = new PostgresQuery({ joinGraph, cubeEvaluator, compiler }, {