fix: sqlAlias isn't used for pre-aggregation table names

Author: paveltiunov

packages/cubejs-schema-compiler/adapter/BaseQuery.js

@@ -1308,15 +1308,16 @@ class BaseQuery {
     throw new Error('Not implemented');
   }
 
-  aliasName(name) {
+  aliasName(name, isPreAggregationName) {
     const path = name.split('.');
     if (path[0] && this.cubeEvaluator.cubeExists(path[0]) && this.cubeEvaluator.cubeFromPath(path[0]).sqlAlias) {
       const cubeName = path[0];
       path.splice(0, 1);
       path.unshift(this.cubeEvaluator.cubeFromPath(cubeName).sqlAlias);
       name = this.cubeEvaluator.pathFromArray(path);
     }
-    return inflection.underscore(name).replace(/\./g, '__');
+    // use single underscore for pre-aggregations to avoid fail of pre-aggregation name replace
+    return inflection.underscore(name).replace(/\./g, isPreAggregationName ? '_' : '__');
   }
 
   newSubQuery(options) {
@@ -1428,7 +1429,7 @@ class BaseQuery {
   }
 
   preAggregationTableName(cube, preAggregationName, skipSchema) {
-    return `${skipSchema ? '' : this.preAggregationSchema() && `${this.preAggregationSchema()}.`}${this.aliasName(`${cube}_${preAggregationName}`)}`;
+    return `${skipSchema ? '' : this.preAggregationSchema() && `${this.preAggregationSchema()}.`}${this.aliasName(`${cube}.${preAggregationName}`, true)}`;
   }
 
   preAggregationSchema() {

packages/cubejs-schema-compiler/test/PreAggregationsTest.js

@@ -140,6 +140,8 @@ describe('PreAggregations', function test() {
       sql: \`
       select * from visitor_checkins
       \`,
+      
+      sqlAlias: 'vc',
 
       measures: {
         count: {
@@ -572,6 +574,7 @@ describe('PreAggregations', function test() {
       console.log(preAggregationsDescription);
 
       const queries = tempTablePreAggregations(preAggregationsDescription);
+      preAggregationsDescription[1].loadSql[0].should.match(/vc_main/);
 
       console.log(JSON.stringify(queries.concat(queryAndParams)));