fix: BigQuery external rollup compatibility: use __ separator for member aliases. Fix missed override.

paveltiunov · paveltiunov · commit c1eb113b35e1 · 2019-07-31T16:14:32.000-07:00
diff --git a/packages/cubejs-schema-compiler/adapter/BigqueryQuery.js b/packages/cubejs-schema-compiler/adapter/BigqueryQuery.js
@@ -50,10 +50,6 @@ class BigqueryQuery extends BaseQuery {
     return new BigqueryFilter(this, filter);
   }
 
-  aliasName(name) {
-    return super.aliasName(name).replace(/\./g, '_');
-  }
-
   dateSeriesSql(timeDimension) {
     return `${timeDimension.dateSeriesAliasName()} AS (${this.seriesSql(timeDimension)})`;
   }

Original file line number	Diff line number	Diff line change
`@@ -50,10 +50,6 @@ class BigqueryQuery extends BaseQuery {`
`50`	`50`	`return new BigqueryFilter(this, filter);`
`51`	`51`	`}`
`52`	`52`
`53`		`- aliasName(name) {`
`54`		`- return super.aliasName(name).replace(/\./g, '_');`
`55`		`- }`
`56`		`-`
`57`	`53`	`dateSeriesSql(timeDimension) {`
`58`	`54`	return `${timeDimension.dateSeriesAliasName()} AS (${this.seriesSql(timeDimension)})`;
`59`	`55`	`}`