fix: Respect MySQL TIMESTAMP strict mode on rollup downloads

paveltiunov · paveltiunov · commit c72ab079d534 · 2020-02-10T23:37:03.000-08:00
diff --git a/packages/cubejs-mysql-driver/driver/MySqlDriver.js b/packages/cubejs-mysql-driver/driver/MySqlDriver.js
@@ -132,6 +132,9 @@ class MySqlDriver extends BaseDriver {
     if (genericType === 'text') {
       return value && value.replace(/[\u0800-\uFFFF]/g, '');
     }
+    if (genericType === 'timestamp' && typeof value === 'string') {
+      return value && value.replace('Z', '');
+    }
     return super.toColumnValue(value, genericType);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,9 @@ class MySqlDriver extends BaseDriver {`
`132`	`132`	`if (genericType === 'text') {`
`133`	`133`	`return value && value.replace(/[\u0800-\uFFFF]/g, '');`
`134`	`134`	`}`
	`135`	`+ if (genericType === 'timestamp' && typeof value === 'string') {`
	`136`	`+ return value && value.replace('Z', '');`
	`137`	`+ }`
`135`	`138`	`return super.toColumnValue(value, genericType);`
`136`	`139`	`}`
`137`	`140`