Skip to content

Commit ca0f1f6

Browse files
committed
fix: TypeError: Cannot read property 'path' of undefined -- Case when partitioned originalSql is resolved for query without time dimension and incremental refreshKey is used
1 parent ae0584d commit ca0f1f6

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

packages/cubejs-schema-compiler/adapter/BaseQuery.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1760,11 +1760,15 @@ class BaseQuery {
17601760
if (!preAggregation.partitionGranularity) {
17611761
throw new UserError(`Incremental refresh key can only be used for partitioned pre-aggregations`);
17621762
}
1763-
refreshKey = this.incrementalRefreshKey(
1764-
preAggregationQueryForSql,
1765-
refreshKey,
1766-
{ window: preAggregation.refreshKey.updateWindow }
1767-
);
1763+
// TOOD Case when partitioned originalSql is resolved for query without time dimension.
1764+
// Consider fallback to not using such originalSql for consistency?
1765+
if (preAggregationQueryForSql.timeDimensions.length) {
1766+
refreshKey = this.incrementalRefreshKey(
1767+
preAggregationQueryForSql,
1768+
refreshKey,
1769+
{ window: preAggregation.refreshKey.updateWindow }
1770+
);
1771+
}
17681772
}
17691773
if (preAggregation.refreshKey.every || preAggregation.refreshKey.incremental) {
17701774
return {

packages/cubejs-server-core/core/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ const devLogger = (level) => (type, { error, warning, ...message }) => {
7373
.concat(R.takeLast(queryMaxLines / 2, formatted));
7474
}
7575
return `${prefix}\n--\n ${formatted.join('\n')}\n--${showRestParams ? `\n${restParams}` : ''}`;
76+
} else if (query) {
77+
return `${prefix}\n--\n${JSON.stringify(query, null, 2)}\n--${showRestParams ? `\n${restParams}` : ''}`;
7678
}
7779
return `${prefix}${showRestParams ? `\n${restParams}` : ''}`;
7880
};

0 commit comments

Comments
 (0)