Skip to content

Commit fadbdf2

Browse files
committed
fix(cubejs-playground): style fixes
1 parent 15ab347 commit fadbdf2

File tree

3 files changed

+24
-9
lines changed

3 files changed

+24
-9
lines changed

packages/cubejs-client-core/dist/cubejs-client-core.umd.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1071,8 +1071,6 @@
10711071
// Unhandled rejections tracking support, NodeJS Promise without it fails @@species test
10721072
if (!IS_NODE$1 && typeof PromiseRejectionEvent != 'function') return true;
10731073
}
1074-
// We need Promise#finally in the pure version for preventing prototype pollution
1075-
if (isPure && !PromiseConstructor.prototype['finally']) return true;
10761074
// We can't use @@species feature detection in V8 since it causes
10771075
// deoptimization and performance degradation
10781076
// https://github.com/zloirock/core-js/issues/679
@@ -1292,7 +1290,7 @@
12921290
: newGenericPromiseCapability(C);
12931291
};
12941292

1295-
if (!isPure && typeof nativePromiseConstructor == 'function') {
1293+
if (typeof nativePromiseConstructor == 'function') {
12961294
nativeThen = nativePromiseConstructor.prototype.then;
12971295

12981296
// wrap native Promise#then for native async functions
@@ -1334,11 +1332,11 @@
13341332
}
13351333
});
13361334

1337-
_export({ target: PROMISE, stat: true, forced: isPure || FORCED }, {
1335+
_export({ target: PROMISE, stat: true, forced: FORCED }, {
13381336
// `Promise.resolve` method
13391337
// https://tc39.github.io/ecma262/#sec-promise.resolve
13401338
resolve: function resolve(x) {
1341-
return promiseResolve(isPure && this === PromiseWrapper ? PromiseConstructor : this, x);
1339+
return promiseResolve(this, x);
13421340
}
13431341
});
13441342

@@ -1799,7 +1797,7 @@
17991797
return getInternalState$1(this).description;
18001798
}
18011799
});
1802-
{
1800+
if (!isPure) {
18031801
redefine(ObjectPrototype, 'propertyIsEnumerable', $propertyIsEnumerable, { unsafe: true });
18041802
}
18051803
}
@@ -2162,7 +2160,7 @@
21622160
if (anyNativeIterator) {
21632161
CurrentIteratorPrototype = objectGetPrototypeOf(anyNativeIterator.call(new Iterable()));
21642162
if (IteratorPrototype$2 !== Object.prototype && CurrentIteratorPrototype.next) {
2165-
if (objectGetPrototypeOf(CurrentIteratorPrototype) !== IteratorPrototype$2) {
2163+
if (!isPure && objectGetPrototypeOf(CurrentIteratorPrototype) !== IteratorPrototype$2) {
21662164
if (objectSetPrototypeOf) {
21672165
objectSetPrototypeOf(CurrentIteratorPrototype, IteratorPrototype$2);
21682166
} else if (typeof CurrentIteratorPrototype[ITERATOR$4] != 'function') {
@@ -2171,6 +2169,7 @@
21712169
}
21722170
// Set @@toStringTag to native iterators
21732171
setToStringTag(CurrentIteratorPrototype, TO_STRING_TAG, true, true);
2172+
if (isPure) iterators[TO_STRING_TAG] = returnThis$2;
21742173
}
21752174
}
21762175

@@ -2181,7 +2180,7 @@
21812180
}
21822181

21832182
// define iterator
2184-
if (IterablePrototype[ITERATOR$4] !== defaultIterator) {
2183+
if ((!isPure || FORCED) && IterablePrototype[ITERATOR$4] !== defaultIterator) {
21852184
createNonEnumerableProperty(IterablePrototype, ITERATOR$4, defaultIterator);
21862185
}
21872186
iterators[NAME] = defaultIterator;

packages/cubejs-playground/src/SchemaPage.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,6 @@ class SchemaPage extends Component {
217217
style={{
218218
background: '#fff',
219219
borderRight: '1px solid #eee',
220-
padding: '0 16px'
221220
}}
222221
className="schema-sidebar"
223222
>

packages/cubejs-playground/src/index.less

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,20 @@
1616
background-color: #6D5AE5;
1717
border-color: #6D5AE5;
1818
}
19+
20+
.schema-sidebar .ant-tabs-top-bar {
21+
padding: 0 16px;
22+
}
23+
24+
.schema-sidebar .ant-menu {
25+
border: 0;
26+
}
27+
28+
.ant-layout-header .ant-menu {
29+
height: 100%;
30+
}
31+
32+
.ant-menu-horizontal .ant-menu-item {
33+
margin-top: 0;
34+
top: -2px;
35+
}

0 commit comments

Comments
 (0)