-
Notifications
You must be signed in to change notification settings - Fork 1.9k
add support for extra params in generating schema for tables. #1990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dataSource
field in generating schema for tables.
Hello @rbsh,
Can you please rebase your branch? And start calling Small notice: Don't forget that Thanks! |
Hey @ovr , what will be 2nd argument for Thanks for the notice. I will lock the version for this package. |
I think it's better to use an object, and call it something like |
Hey @ovr, I am done with the changes. You can review the PR. |
Thank you @rsbh for contribution! 🍰 🥮 |
* feat(schema-compiler): add support for `dataSource` field in scaffolding template * refactor: replace dataSource with extraParams object * refactor: set extraParams to empty object as default arg * chore: fix test failure due to merge issue * feat: pass dataSource to generateFilesByTableNames in cli and DevServer * refactor: fix lint issues in test file * refactor: rename extraParams to schemaContext
Check List
This changes will add support to pass
extraParams
objects while creating the schema from tables.I am using
generateFilesByTableNames
function to dynamically generate schema for all the tables but I have to manually adddataSource
to the schema files after generating.This change will add options to pass
dataSource
along with other params to the cube schema file