Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup PG pre aggregations #201

Merged
merged 4 commits into from
Sep 5, 2019

Conversation

landyrev
Copy link
Contributor

@landyrev landyrev commented Sep 3, 2019

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#200

Description of Changes Made (if issue reference is not provided)

PostgresDriver not has it's own method uploadTable, which uploads all data using single query, which makes uploading process faster.

@landyrev landyrev changed the title Speedup PG aggregations Speedup PG pre aggregations Sep 3, 2019
@paveltiunov
Copy link
Member

paveltiunov commented Sep 3, 2019

@landyrev Hey Alexey! Thanks for providing this! Looks great! There're 2 comments to resolve and we good to merge.

@landyrev
Copy link
Contributor Author

landyrev commented Sep 4, 2019

Done with comments, thank you

@paveltiunov paveltiunov merged commit 7abf504 into cube-js:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants