feat: Postgres HLL improvements: always round to int (#611) Thanks to @milanbella!

milanbella · milan.bella@ibm.com · norbertbede · web-flow · commit 680a613a4118 · 2020-04-23T13:18:36.000-07:00
* pg_approx_hll

* pg_approx_hll

* pg_approx_hll

* pg_approx_hll

* pg_approx_hll

Co-authored-by: milan.bella@ibm.com &lt;milan.bella@ibm.com&gt;
Co-authored-by: Norbert Bede &lt;norbert.bede@cloudempiere.com&gt;
diff --git a/packages/cubejs-schema-compiler/adapter/PostgresQuery.js b/packages/cubejs-schema-compiler/adapter/PostgresQuery.js
@@ -35,11 +35,11 @@ class PostgresQuery extends BaseQuery {
   }
 
   hllMerge(sql) {
-    return `hll_cardinality(hll_union_agg(${sql}))`;
+    return `round(hll_cardinality(hll_union_agg(${sql})))`;
   }
 
   countDistinctApprox(sql) {
-    return `hll_cardinality(hll_add_agg(hll_hash_any(${sql})))`;
+    return `round(hll_cardinality(hll_add_agg(hll_hash_any(${sql}))))`;
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -35,11 +35,11 @@ class PostgresQuery extends BaseQuery {`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`hllMerge(sql) {`
`38`		- return `hll_cardinality(hll_union_agg(${sql}))`;
	`38`	+ return `round(hll_cardinality(hll_union_agg(${sql})))`;
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`countDistinctApprox(sql) {`
`42`		- return `hll_cardinality(hll_add_agg(hll_hash_any(${sql})))`;
	`42`	+ return `round(hll_cardinality(hll_add_agg(hll_hash_any(${sql}))))`;
`43`	`43`	`}`
`44`	`44`	`}`
`45`	`45`