fix: respect npm proxy settings (#1137)

Author: vasilev-alex

packages/cubejs-server-core/dev/PackageFetcher.js

@@ -1,10 +1,9 @@
 const fs = require('fs-extra');
-const fetch = require('node-fetch').default;
 const decompress = require('decompress');
 const decompressTargz = require('decompress-targz');
 const path = require('path');
 
-const { executeCommand } = require('./utils');
+const { executeCommand, proxyFetch } = require('./utils');
 
 class PackageFetcher {
   constructor(repo) {
@@ -26,7 +25,7 @@ class PackageFetcher {
   }
 
   async manifestJSON() {
-    const response = await fetch(
+    const response = await proxyFetch(
       `https://api.github.com/repos/${this.repo.owner}/${this.repo.name}/contents/manifest.json`
     );
 
@@ -37,7 +36,7 @@ class PackageFetcher {
     const url = `https://github.com/${this.repo.owner}/${this.repo.name}/archive/master.tar.gz`;
     const writer = fs.createWriteStream(this.repoArchivePath);
 
-    (await fetch(url)).body.pipe(writer);
+    (await proxyFetch(url)).body.pipe(writer);
 
     return new Promise((resolve, reject) => {
       writer.on('finish', resolve);

packages/cubejs-server-core/dev/utils.js

@@ -1,6 +1,9 @@
 const fs = require('fs-extra');
 const path = require('path');
 const spawn = require('cross-spawn');
+const fetch = require('node-fetch');
+const HttpsProxyAgent = require('http-proxy-agent');
+const { exec } = require('child_process');
 
 async function fileContentsRecursive(dir, rootPath, includeNodeModules) {
   if (!rootPath) {
@@ -54,7 +57,38 @@ function executeCommand(command, args, options = {}) {
   });
 }
 
+function getCommandOutput(command) {
+  return new Promise((resolve, reject) => {
+    exec(command, (error, stdout) => {
+      if (error) {
+        reject(error.message);
+        return;
+      }
+      resolve(stdout);
+    });
+  });
+}
+
+async function proxyFetch(url) {
+  const [proxy] = (await Promise.all([
+    getCommandOutput('npm config get https-proxy'),
+    getCommandOutput('npm config get proxy'),
+  ]))
+    .map((s) => s.trim())
+    .filter((s) => !['null', 'undefined', ''].includes(s));
+
+  return fetch(
+    url,
+    proxy
+      ? {
+        agent: new HttpsProxyAgent(proxy),
+      }
+      : {}
+  );
+}
+
 module.exports = {
   fileContentsRecursive,
   executeCommand,
+  proxyFetch
 };

packages/cubejs-server-core/package.json

@@ -34,6 +34,7 @@
     "decompress": "^4.2.1",
     "decompress-targz": "^4.1.1",
     "fs-extra": "^8.1.0",
+    "http-proxy-agent": "^4.0.1",
     "jsonwebtoken": "^8.4.0",
     "lru-cache": "^5.1.1",
     "node-fetch": "^2.6.0",

packages/cubejs-server-core/yarn.lock

@@ -1064,6 +1064,11 @@
     "@types/istanbul-reports" "^1.1.1"
     "@types/yargs" "^13.0.0"
 
+"@tootallnate/once@1":
+  version "1.1.2"
+  resolved "https://registry.yarnpkg.com/@tootallnate/once/-/once-1.1.2.tgz#ccb91445360179a04e7fe6aff78c00ffc1eeaf82"
+  integrity sha512-RbzJvlNzmRq5c3O09UipeuXno4tA1FE6ikOjxZK0tuxVv3412l64l5t1W5pj4+rJq9vpkm/kwiR07aZXnsKPxw==
+
 "@types/babel__core@^7.1.0":
   version "7.1.3"
   resolved "https://registry.yarnpkg.com/@types/babel__core/-/babel__core-7.1.3.tgz#e441ea7df63cd080dfcd02ab199e6d16a735fc30"
@@ -1207,6 +1212,13 @@ acorn@^7.1.0:
   resolved "https://registry.yarnpkg.com/acorn/-/acorn-7.1.1.tgz#e35668de0b402f359de515c5482a1ab9f89a69bf"
   integrity sha512-add7dgA5ppRPxCFJoAGfMDi7PIBXq1RtGo7BhbLaxwrXPOmw8gq48Y9ozT01hUKy9byMjlR20EJhu5zlkErEkg==
 
+agent-base@6:
+  version "6.0.1"
+  resolved "https://registry.yarnpkg.com/agent-base/-/agent-base-6.0.1.tgz#808007e4e5867decb0ab6ab2f928fbdb5a596db4"
+  integrity sha512-01q25QQDwLSsyfhrKbn8yuur+JNw0H+0Y4JiGIKd3z9aYk/w/2kxD/Upc+t2ZBBSUNff50VjPsSW2YxM8QYKVg==
+  dependencies:
+    debug "4"
+
 ajv@^6.10.0, ajv@^6.10.2, ajv@^6.5.5:
   version "6.12.0"
   resolved "https://registry.yarnpkg.com/ajv/-/ajv-6.12.0.tgz#06d60b96d87b8454a5adaba86e7854da629db4b7"
@@ -1968,6 +1980,13 @@ debug@3.2.6, debug@^3.2.6:
   dependencies:
     ms "^2.1.1"
 
+debug@4:
+  version "4.2.0"
+  resolved "https://registry.yarnpkg.com/debug/-/debug-4.2.0.tgz#7f150f93920e94c58f5574c2fd01a3110effe7f1"
+  integrity sha512-IX2ncY78vDTjZMFUdmsvIRFY2Cf4FnD0wRs+nQwJU8Lu99/tPFdb0VybiiMTPe3I6rQmwsqQqRBvxU+bZ/I8sg==
+  dependencies:
+    ms "2.1.2"
+
 debug@^4.0.1, debug@^4.1.0, debug@^4.1.1:
   version "4.1.1"
   resolved "https://registry.yarnpkg.com/debug/-/debug-4.1.1.tgz#3b72260255109c6b589cee050f1d516139664791"
@@ -3075,6 +3094,15 @@ http-errors@~1.6.2:
     setprototypeof "1.1.0"
     statuses ">= 1.4.0 < 2"
 
+http-proxy-agent@^4.0.1:
+  version "4.0.1"
+  resolved "https://registry.yarnpkg.com/http-proxy-agent/-/http-proxy-agent-4.0.1.tgz#8a8c8ef7f5932ccf953c296ca8291b95aa74aa3a"
+  integrity sha512-k0zdNgqWTGA6aeIRVpvfVob4fL52dTfaehylg0Y4UvSySvOq/Y+BOyPrgpUrA7HylqvU8vIZGsRuXmspskV0Tg==
+  dependencies:
+    "@tootallnate/once" "1"
+    agent-base "6"
+    debug "4"
+
 http-signature@~1.2.0:
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/http-signature/-/http-signature-1.2.0.tgz#9aecd925114772f3d95b65a60abb8f7c18fbace1"