Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): tableau get_expr query support #4421

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Conversation

gandronchik
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #4421 (cd6e46c) into master (1550774) will increase coverage by 0.06%.
The diff coverage is 89.74%.

@@            Coverage Diff             @@
##           master    #4421      +/-   ##
==========================================
+ Coverage   69.52%   69.59%   +0.06%     
==========================================
  Files         241      241              
  Lines       23478    23512      +34     
  Branches     2612     2612              
==========================================
+ Hits        16324    16363      +39     
+ Misses       6851     6846       -5     
  Partials      303      303              
Flag Coverage Δ
cube-backend 58.82% <ø> (+0.04%) ⬆️
cubesql 79.04% <89.74%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/engine/udf.rs 85.47% <83.33%> (-0.08%) ⬇️
rust/cubesql/cubesql/src/compile/mod.rs 70.67% <85.71%> (+0.03%) ⬆️
...t/cubesql/cubesql/src/compile/rewrite/converter.rs 82.09% <91.30%> (+0.88%) ⬆️
...pile/engine/information_schema/postgres/pg_type.rs 98.75% <100.00%> (ø)
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 65.08% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a9d059...cd6e46c. Read the comment docs.

@gandronchik gandronchik changed the title chore(cubesql): get_expr query support (in progress) feat(cubesql): get_expr query support Apr 25, 2022
@gandronchik gandronchik marked this pull request as ready for review April 25, 2022 08:48
@gandronchik gandronchik requested a review from a team as a code owner April 25, 2022 08:48
@gandronchik gandronchik changed the title feat(cubesql): get_expr query support feat(cubesql): tableau get_expr query support Apr 25, 2022
@ovr ovr merged commit 4d4918f into master Apr 25, 2022
@ovr ovr deleted the cubesql-get_expr-query branch April 25, 2022 17:04
@rpaik rpaik added this to In Progress in Roadmap 2022 Q1 via automation May 3, 2022
@rpaik rpaik added the Roadmap: 2022 Q1 Cube roadmap for Q1 of 2022 label May 3, 2022
@rpaik rpaik linked an issue May 3, 2022 that may be closed by this pull request
7 tasks
@rpaik rpaik moved this from In Progress to Done in Roadmap 2022 Q1 May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Roadmap: 2022 Q1 Cube roadmap for Q1 of 2022
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Epic: Connectors for additional BI tools
3 participants