Skip to content

Commit

Permalink
feat: Add role parameter to driver options (#448) Thanks to @smbkr!
Browse files Browse the repository at this point in the history
Fixes #447
  • Loading branch information
smbkr authored Feb 26, 2020
1 parent 9123be3 commit 9bfb71d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/Cube.js-Backend/Connecting-to-the-Database.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ The table below shows which environment variables are used for different databas
| AWS Athena | `CUBEJS_AWS_KEY`, `CUBEJS_AWS_SECRET`, `CUBEJS_AWS_REGION`, `CUBEJS_AWS_S3_OUTPUT_LOCATION` |
| Google Bigquery | `CUBEJS_DB_BQ_PROJECT_ID`, `CUBEJS_DB_BQ_KEY_FILE or CUBEJS_DB_BQ_CREDENTIALS` |
| MongoDB | `CUBEJS_DB_HOST`, `CUBEJS_DB_NAME`, `CUBEJS_DB_PORT`, `CUBEJS_DB_USER`, `CUBEJS_DB_PASS`, `CUBEJS_DB_SSL`, `CUBEJS_DB_SSL_CA`, `CUBEJS_DB_SSL_CERT`, `CUBEJS_DB_SSL_CIPHERS`, `CUBEJS_DB_SSL_PASSPHRASE` |
| Snowflake | `CUBEJS_DB_SNOWFLAKE_ACCOUNT`, `CUBEJS_DB_SNOWFLAKE_REGION`, `CUBEJS_DB_SNOWFLAKE_WAREHOUSE`, `CUBEJS_DB_NAME`, `CUBEJS_DB_USER`, `CUBEJS_DB_PASS`|
| Snowflake | `CUBEJS_DB_SNOWFLAKE_ACCOUNT`, `CUBEJS_DB_SNOWFLAKE_REGION`, `CUBEJS_DB_SNOWFLAKE_WAREHOUSE`, `CUBEJS_DB_SNOWFLAKE_ROLE`, `CUBEJS_DB_NAME`, `CUBEJS_DB_USER`, `CUBEJS_DB_PASS`|
| Presto | `CUBEJS_DB_HOST`, `CUBEJS_DB_PORT`, `CUBEJS_DB_CATALOG`, `CUBEJS_DB_SCHEMA`, `CUBEJS_DB_USER`, `CUBEJS_DB_PASS` |

## Notes
Expand Down
4 changes: 3 additions & 1 deletion packages/cubejs-snowflake-driver/driver/SnowflakeDriver.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ class SnowflakeDriver extends BaseDriver {
account: process.env.CUBEJS_DB_SNOWFLAKE_ACCOUNT,
region: process.env.CUBEJS_DB_SNOWFLAKE_REGION,
warehouse: process.env.CUBEJS_DB_SNOWFLAKE_WAREHOUSE,
role: process.env.CUBEJS_DB_SNOWFLAKE_ROLE,
database: process.env.CUBEJS_DB_NAME,
username: process.env.CUBEJS_DB_USER,
password: process.env.CUBEJS_DB_PASS,
Expand All @@ -26,7 +27,8 @@ class SnowflakeDriver extends BaseDriver {
'CUBEJS_DB_PASS',
'CUBEJS_DB_SNOWFLAKE_ACCOUNT',
'CUBEJS_DB_SNOWFLAKE_REGION',
'CUBEJS_DB_SNOWFLAKE_WAREHOUSE'
'CUBEJS_DB_SNOWFLAKE_WAREHOUSE',
'CUBEJS_DB_SNOWFLAKE_ROLE'
];
}

Expand Down

0 comments on commit 9bfb71d

Please sign in to comment.