Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cube Views implementation #5278

Merged
merged 9 commits into from
Oct 2, 2022
Merged

feat: Cube Views implementation #5278

merged 9 commits into from
Oct 2, 2022

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Sep 12, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

#5044

@paveltiunov paveltiunov requested a review from a team as a code owner September 12, 2022 00:16
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Base: 75.69% // Head: 61.14% // Decreases project coverage by -14.55% ⚠️

Coverage data is based on head (09315d1) compared to base (2e85182).
Patch coverage: 69.95% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5278       +/-   ##
===========================================
- Coverage   75.69%   61.14%   -14.56%     
===========================================
  Files         275      140      -135     
  Lines       33010    11985    -21025     
  Branches     2933     2933               
===========================================
- Hits        24987     7328    -17659     
+ Misses       7516     4367     -3149     
+ Partials      507      290      -217     
Flag Coverage Δ
cube-backend 61.14% <69.95%> (+1.03%) ⬆️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bejs-schema-compiler/src/compiler/CubeValidator.js 96.74% <ø> (ø)
...schema-compiler/src/compiler/DataSchemaCompiler.js 50.81% <0.00%> (-0.57%) ⬇️
...ejs-schema-compiler/src/adapter/PreAggregations.js 55.38% <46.34%> (+0.22%) ⬆️
...s/cubejs-schema-compiler/src/adapter/BaseFilter.js 55.91% <66.66%> (+0.17%) ⬆️
...s/cubejs-schema-compiler/src/compiler/JoinGraph.js 84.37% <76.47%> (-2.07%) ⬇️
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 70.81% <82.75%> (+0.97%) ⬆️
...bejs-schema-compiler/src/compiler/CubeEvaluator.js 74.86% <86.48%> (+2.86%) ⬆️
...cubejs-schema-compiler/src/compiler/CubeSymbols.js 90.85% <92.85%> (+0.85%) ⬆️
...er/transpilers/CubeCheckDuplicatePropTranspiler.ts 96.15% <100.00%> (ø)
.../compiler/transpilers/CubePropContextTranspiler.ts 98.59% <100.00%> (ø)
... and 177 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paveltiunov paveltiunov requested a review from a team as a code owner September 12, 2022 04:22
@paveltiunov paveltiunov merged commit 9937356 into master Oct 2, 2022
@paveltiunov paveltiunov deleted the cube-views branch October 2, 2022 18:20
@rpaik rpaik added Epic Major changes and features from the core team. Roadmap: 2022 Q3 Cube roadmap for Q3 of 2022 labels Oct 10, 2022
@rpaik rpaik linked an issue Oct 10, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Major changes and features from the core team. Roadmap: 2022 Q3 Cube roadmap for Q3 of 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epic: Build metrics in Cube data model
2 participants