Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSSQL Storage #110

Open
kedoska opened this issue Jul 16, 2019 · 5 comments
Open

MSSQL Storage #110

kedoska opened this issue Jul 16, 2019 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kedoska
Copy link

kedoska commented Jul 16, 2019

Hi there,

Very interesting tools. Thank you in advance.
I see that MSSQL is not in the roadmap.

How could it be implemented? Adding a dedicated datastore would be enough?
I could eventually help in the process

@cube2222
Copy link
Owner

Hey, it would basically be copy pasting the postgres data source and changing the sql generation parts to fit the dialect. MySQL support was added in like half an hour as a copy paste of the postgres package.

@JasiekChomiak JasiekChomiak added the enhancement New feature or request label Jul 17, 2019
@cube2222
Copy link
Owner

I've written a small datasource contribution guide if that helps: https://github.com/cube2222/octosql/tree/master/storage

@cube2222 cube2222 added help wanted Extra attention is needed good first issue Good for newcomers and removed help wanted Extra attention is needed labels Jul 22, 2019
@Xirui
Copy link

Xirui commented Apr 1, 2022

@cube2222 this tool has been very useful to me.

Just want to contribute to this feature, though the link to the contribution guide is broken.

@cube2222
Copy link
Owner

cube2222 commented Apr 1, 2022

Hey @Xirui, glad to hear that!

OctoSQL doesn't accept contributions right now, as is detailed in the README: https://github.com/cube2222/octosql#contributing

However, since this issue was created, OctoSQL adopted a plugin model for datasources, so you can actually create this yourself, in your own repository.

There's no guide right now, but you should be able to base yourself on the MySQL or PostgreSQL plugins:

Happy to help and answer any questions during the process!

@Xirui
Copy link

Xirui commented Apr 2, 2022

Thanks @cube2222, I will have a go with that, looks quite straight-forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants