Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Typo #19

Closed
bhsmither opened this issue Jan 6, 2015 · 1 comment
Closed

CSS Typo #19

bhsmither opened this issue Jan 6, 2015 · 1 comment
Assignees
@abrookbanks
Labels
bug
Milestone
6.0.0b2

Comments

@bhsmither
Copy link
Contributor

In /skins/foundation/css/cubecart.common.css, line 3, there is:
font-size: 1.375rem;
rem is not valid.

See also cubecart.css, line 138.

And plenty of occasions in foundation.css and foundation.min.css.
@abrookbanks abrookbanks added the bug label Jan 7, 2015
abrookbanks pushed a commit that referenced this issue Jan 7, 2015
Fixed issue #19
89aee4d
abrookbanks pushed a commit that referenced this issue Jan 7, 2015
Fixed issue #19
32d13a9
@abrookbanks abrookbanks added this to the 6.0.0b2 milestone Jan 7, 2015
@abrookbanks abrookbanks self-assigned this Jan 7, 2015
@bhsmither
Copy link
Contributor Author

This is very strange. My browser's addon, Firebug, is not rejecting the rem dimension.

http://caniuse.com/rem

I was not aware of this.

briansandall added a commit to briansandall/v6 that referenced this issue Dec 1, 2016
@briansandall
Resolves issue cubecart#19
645208e
@mrobertbell mrobertbell mentioned this issue Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrookbanks abrookbanks

Labels
bug
Projects
None yet
Milestone
6.0.0b2
Development

No branches or pull requests
2 participants
@bhsmither @abrookbanks