Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Call to Function #37

Closed
bhsmither opened this issue Jan 9, 2015 · 2 comments
Closed

Incorrect Call to Function #37

bhsmither opened this issue Jan 9, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@bhsmither
Copy link
Contributor

With respect to:
https://github.com/cubecart/v5.2.14/issues/117
The call made in cart.class.php, line 240 (and the same issue still exists in CC5) sends $options_identifier_string to Catalogue->getProductData() in the wrong argument position.

Perhaps this has escaped causing problems so far, but the potential exists.

abrookbanks pushed a commit that referenced this issue Jan 12, 2015
@abrookbanks abrookbanks added this to the 6.0.0b2 milestone Jan 12, 2015
@abrookbanks abrookbanks self-assigned this Jan 12, 2015
@abrookbanks
Copy link
Member

This concerns me a bit.

  1. Why haven't other issues around this been found.
  2. Will fixing this actually break it.

Need to test checkout with stock on options.

@abrookbanks
Copy link
Member

From my tests all seems fine here. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants