Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to existing entries in default instance settings do not persist #1095

Closed
3 tasks done
FrozenSoda opened this issue May 5, 2024 · 6 comments
Closed
3 tasks done

Comments

@FrozenSoda
Copy link
Contributor

Bug Report

System Information

Operating System

Ubuntu Server 22.04.4

AMP Version and Build Date

2.5.0.8 - 20240502.1

AMP Release Stream

Mainline

I confirm:

  • that I have searched for an existing bug report for this issue.
  • that I am using the latest available version of AMP.
  • that my operating system is up-to-date.

Symptoms

What are you trying to do?

Edit an existing entry in Configuration > New Instance Defaults > Default Settings.

What are you expecting to happen?

That the changes are saved.

What is actually happening?

The node and value gets reset after refreshing the page, even if you attempt to save your changes by pressing enter or clicking outside the textbox.

Reproduction

  1. Go to Configuration > New Instance Defaults > Default Settings.
  2. Edit any field under Node or Value. For example try to change the value of Core.Privacy.AllowAnalytics to false.
  3. Refresh the page by pressing F5.
  4. Navigate to Default Settings again and observe that the changes were not saved.
@Greelan
Copy link
Contributor

Greelan commented May 5, 2024

After entering the key and value, did you press + at the right?

@FrozenSoda
Copy link
Contributor Author

After entering the key and value, did you press + at the right?

When modifying an existing entry, there is only the X button to delete it.

@Greelan
Copy link
Contributor

Greelan commented May 5, 2024

That's because there is no ability to edit existing entries atm. Has been requested

@FrozenSoda
Copy link
Contributor Author

That's because there is no ability to edit existing entries atm. Has been requested

Oh, okay. Maybe the textboxes should be readonly in the meantime to prevent confusion

@PhonicUK
Copy link
Contributor

PhonicUK commented Jun 4, 2024

This has been addressed in a subsequent update.

@FrozenSoda
Copy link
Contributor Author

This has been addressed in a subsequent update.

The issue does not seem to be fixed, it is still present on AMP version 2.5.1.6 - 20240816.1. But maybe you mean that a fix has been made but not yet released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants