Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations not working #1122

Closed
3 tasks done
BroOtti opened this issue Jun 15, 2024 · 1 comment
Closed
3 tasks done

Translations not working #1122

BroOtti opened this issue Jun 15, 2024 · 1 comment

Comments

@BroOtti
Copy link

BroOtti commented Jun 15, 2024

Bug Report

System Information

┏━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Key                  ┃ Value                                 ┃
┣━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┫
┃ Operating System     ┃ Linux - Debian GNU/Linux 12 on x86_64 ┃
┃ Product              ┃ AMP 'Callisto' v2.5.0.14 (Mainline)   ┃
┃ Virtualization       ┃ ProxmoxLXC                            ┃
┃ Application          ┃ Application Deployment                ┃
┃ Module               ┃ ADSModule                             ┃
┃ Running in Container ┃ No                                    ┃
┃ Current State        ┃ Indeterminate                         ┃
┗━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛

I confirm:

  • that I have searched for an existing bug report for this issue.
  • that I am using the latest available version of AMP.
  • that my operating system is up-to-date.

Symptoms

  • What are you trying to do?
    Using a translation
  • What are you expecting to happen?
    The translation works all over AMP
  • What is actually happening? ('Nothing' is not an acceptable answer!)
    As soon as I enter a folder in File Manager and reload the page, the JSON file request comes back as the AMP login page and can't be applied and also breaks the page from working. A refresh on the main domain gets it to work again.
    I guess the problems are related to the introduction of the Navigation URLs

Reproduction

  1. Download a translation in the WebRoot/Locale directory through the AMP File Manager. Example: de.json
  2. Apply the translation with the URL https://amp.example.com/?lang=de and see it working
  3. Go to the File Manager and navigate to the ADS directory. Note, the ?lang=de disappears in the URL
  4. Reload the page by hitting F5
  5. You get a blank screen and in the browser console you see something like SyntaxError: Unexpected token '<', "<!DOCTYPE "... is not valid JSON. The network tab of the dev tools shows you the json request came back with an AMP login page. The GET request tries to get it from https://amp.example.com/filemanager/__VDS__ADS01/Locale/de.json
  6. Navigate back to your AMP https://amp.example.com and see it working again.

Some users already mentioned this on discord, but I haven't seen an open Issue to the problem.

@PhonicUK
Copy link
Contributor

This has been fixed in the most recent update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants