-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMP 2.4.6.6 on Windows Server 2019: Startup of generic application no longer possible #933
Comments
You could be facing the issue where the templates are not up to date on both controller and target? For BattleBit, do you have the Server Branch setting under SteamCMD and Updates? If not, then the templates have not been downloaded and applied correctly. Note that you need Git installed to fetch repo branches on windows. |
my controller runs on linux and the target is the windows server, both have git installed and I fetched the latest templates on both instances hmm |
Do you have the Server Branch setting? |
Yeah, it is set to Public (default), also fails with other settings |
I tried other generic templates from the default AMP repo and all fail with the same error, Arma, euro truck, CS2 etc |
The whole setup works fine with AMP 2.4.6.4, but as soon as you use 2.4.6.6 it is broken. (Note that other apps not using generic templates work totally fine) |
It might be worth looking around to see if you have any empty required fields. From the update notes:
Just an idea to tinker with until Mike is available to fix things. |
But from the notes required fields should be highlighted as red? Not seeing any. Another thing I noticed is that settings are not getting saved anymore. My fault for not snapshotting the vm, but I would downgrade now.^^ Since it fails in the DL/update stage with steamCMD i would assume it is a steam cmd setting... but for battlebit the branch is set, and other games like CS2 don't have that option at all |
There are no "Required" fields in the config manifest for BB. Looks like Mike has done his old trick and mistakenly made the presence of the field mandatory, which won't work because virtually no template will have it (given it was non-functional previously). He previously had this issue with the client ID for steamcmd update stages. |
Either that or it's an issue with the changes he made to the SteamCMD update stages to deal with auth login. |
FWIW, I don't see this issue on Linux. |
Yes, I also have Linux targets and works fine there. I only have the issue on windows. For the BB template also saving the settings fails with:
it is already too late for me now, but I will check tomorrow on another clean windows server (which is standalone and not a target) Do not know why, but the .Where linq in GetSharedVariables() throws that NullException all the time. No idea why source is null though. Seems more related to that one Method and not to steamcmd itself. Thanks for your help btw :) |
That suggests the error is more likely to do with the Required field change |
I can confirm this myself. I also get the following in Console when shutting down an instance to restart it.
|
That just looks like a file perms error, be sure to use AMP's SFTP or web file manager, because if you use the windows file explorer, you'll mess up the file perms. |
That's just it, I didn't use windows file explorer for anything dealing with AMP. I never have SFTP enabled and will use the web file manager where needed but this is a fresh install and start up. Haven't used SFTP, web fie manager, or windows file explorer. |
Oh weird, that web address just returns your IP, so I wonder if it just errored out during that request for some off reason. (worked for me in my browser when I navigated to the site) |
Possible. |
This isn't anything to do with this issue. This is an attack attempt by a random 3rd party trying to see if they can perform a GET on an URL and get a response that makes sense. You can ignore this. |
I can't reproduce this - it looks like the circumstance it would happen under is if the ports data has been damaged and is consequently null. |
How would this get damaged? I am doing this on a newly installed AMP instance and creating new generic instances. https://discourse.cubecoders.com/t/startup-issue-with-dayz-original-cannot-update-or-start-dayz-server/6133/1 reported the same issue, maybe they have additional information. I am trying this again now on a fresh standalone instance (since the one I tested this with is a target) |
I did the following now @PhonicUK |
I see the issue. I just updated my Windows VM, and in GenericModule.kvp for one of the instances:
AMP is stripping out the ports information. This is an AMP issue. If the kvp is being damaged, it is AMP causing it. |
I see this happen when the instance is managed. Rather than just managing it straight away, AMP reconfigures the instance, and in the process of doing so strips out the ports information. |
I don't even see it as a bad JSON issue. If I replace the App.Ports line with the default information from the relevant template (making sure port numbers match what AMP thinks the instance is on), AMP still strips it out. |
Looking into it |
Can someone affected by this get me a full debug log from startup to start? |
|
Or if you want ADS:
|
I see the reconfiguring that happens when the instance is managed is because of the "no licence" shenanigans... sheesh |
Aah I think I know what's up, it's to do with the new dictionary setters. Hold fire... |
Yeah dw I see what's up. Working on it :) |
1 similar comment
Yeah dw I see what's up. Working on it :) |
Fixed in the patch that just dropped. |
So instances with no port information have to be fixed manually now? |
Bug Report
System Information
I confirm:
Symptoms
Start an upgraded or newly installed generic template with the versions mentioned above.
The instances should start.
It is not possible to start the instance. Tried Arma3, CS2 + the dev templates for BattleBit by Greelan. All 3 throw the same error about a missing source param.
Reproduction
Enter reproductions steps here.
The text was updated successfully, but these errors were encountered: