$ExternalIP randomly failing in Generic

[Greelan]

Bug Report

System Information

• Windows or Linux
• 2.4.6.6
• Mainline

I confirm:

• that I have searched for an existing bug report for this issue.
• that I am using the latest available version of AMP.
• that my operating system is up-to-date.

Symptoms

A number of Generic templates use $ExternalIP to populate the public IP.

This seems to randomly fail. On some occasions when a server is started, the IP will populate correctly; on others, it does not.

It's almost like if a fetch fails for some reason, any existing data is overwritten with an empty value, and there is no error handling to ensure a retry until good data is obtained.

Can this please be looked at?

Reproduction

See above.

[PhonicUK]

I've changed the logic for this so it'll try multiple providers, and it'll try multiple times before giving up. There's no 'existing' data per-se, AMP works it out once when it starts up.

[PhonicUK]

Fixed in 2.5