Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Competitions need a location #22

Closed
jfly opened this issue Nov 5, 2014 · 3 comments
Closed

Competitions need a location #22

jfly opened this issue Nov 5, 2014 · 3 comments
Milestone

Comments

@jfly
Copy link
Member

jfly commented Nov 5, 2014

Ok, so competitions need a lot of things, but once we have their physical locations, we could do something cool like showing a map of all ongoing/soon/recent competitions on the home page, rather than a boring list.

@jfly jfly added this to the Phase 1 milestone Nov 5, 2014
@jfly
Copy link
Member Author

jfly commented Nov 6, 2014

jbmertens added a commit that referenced this issue Jan 3, 2015
…like the behvaior, and I think we want to store addresses too anyways; so the Logicify/jquery-locationpicker-plugin or something else might be better here.
@jbmertens
Copy link
Member

This is now done just the google maps API (rather than a library on top of it). I'm fairly happy with how it works right now, as of cc83faa.

It would be great to extract city/state/country data using on top of this too, as mentioned in #96, or to re-use this to ask competitors for locations like in #24.

I'm going to close this issue for now, and leave additional features for other issues.

@jfly
Copy link
Member Author

jfly commented Jan 5, 2015

I'm going to reopen this issue, as it looks like our map rendering isn't done reactively, so when someone else changes the location, the page doesn't update. I think the fix will be as easy as running setCompetitionLocationMap() inside of a template.autorun() here cc83faa#diff-1099b835a605090837b1e9f03adb11dcR266.

@jfly jfly reopened this Jan 5, 2015
@jfly jfly closed this as completed in 6504600 Jan 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants