Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Add expected number of solves and completed number of solves to the Round schema #81

Closed
jfly opened this issue Dec 21, 2014 · 2 comments · Fixed by #179
Closed

Add expected number of solves and completed number of solves to the Round schema #81

jfly opened this issue Dec 21, 2014 · 2 comments · Fixed by #179
Assignees
@jfly
Labels
data entry scaling
Milestone
Phase 1

Comments

@jfly
Copy link
Member

jfly commented Dec 21, 2014

This will let us reimplement getCompetitorsDoneAndTotal() and getLastRoundResultsCount() in editCompetition.js without hitting unacceptable performance problems.
@jfly jfly added the scaling label Dec 21, 2014
@jfly jfly added this to the Phase 1 milestone Dec 21, 2014
jfly added a commit that referenced this issue Dec 21, 2014
@jfly
Removed some <<< and replaced them with links to #81
a95f3d5
@jfly jfly mentioned this issue Dec 24, 2014
Closed
This was referenced Dec 31, 2014
Closed
Closed
@jfly jfly self-assigned this Jan 19, 2015
@jfly
Copy link
Member Author

jfly commented Jan 31, 2015

Remember that since we're denormalizing a bit, we need to recompute these numbers when competitors are added to a round and when a rounds's format changes.

This brings up a tangential issue: what if someone picks a soft cutoff, then changes the number of solves in the round? We probably don't handle that case elegantly. I'm not really sure what we should do, though.

@jfly
Copy link
Member Author

jfly commented Feb 1, 2015 

// TODO - recompute on soft cutoff change, and when competitors are
// checkined/out (this also requires handling the "please advanced" trick..

@jfly jfly closed this as completed in f07d02c Feb 3, 2015
jfly added a commit that referenced this issue Feb 3, 2015
@jfly
Merge pull request #177 from jfly/master
b86cd8a 
Add expected number of solves and completed number of solves to the Round schema. This fixes #81
@jfly jfly mentioned this issue Feb 3, 2015
Open
jfly added a commit that referenced this issue Feb 3, 2015
@jfly
Revert "Add expected number of solves and completed number of solves …
3e980f2 
…to the Round schema. This fixes #81"
jfly added a commit to jfly/ccm that referenced this issue Feb 3, 2015
@jfly
Round done and total attributes added! They are recomputed whenever we
839717d 
sort a round. This fixes cubing#81.
@jfly jfly mentioned this issue Feb 3, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jfly jfly

Labels
data entry scaling
Projects
None yet
Milestone
Phase 1
Development

Successfully merging a pull request may close this issue.

Round done and total attributes added! They are recomputed whenever we sort a round. jfly/ccm
1 participant
@jfly