-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cube rotations cause simultaneous moves to break #325
Comments
The simultaneous move indexer is limited to algs with 100 moves:
This is just a safeguard because the implementation is unoptimized, but I suppose we could raise it a bit higher to account for BLD solves. Do you know of any good stats for how long 3BLD reconstructions get? |
This document gives some statistics for 3BLD using 3-style (https://www.speedcubing.pl/content/3bld-statistics.pdf). Using just basic UF/UFR buffer, most solves require 10.26 basic 3-style algs. Assuming that most basic 3-style algs require 11 moves, we get an average of 112.86 moves per solve. This isn't a very good metric since we aren't considering the full distribution of solves. However, based on this rough calculation I would say raising the limit to 150 moves would be sufficient. If someone used Orozco instead, this limit would need to be nearly doubled (maybe 250 moves). |
Sounds like 256 moves should reasonable cover "normal" reconstructions — I'll bump it to that! |
…up to 256. Closes #325 This also fixes the calculation to prevent URLs like https://alpha.twizzle.net/edit/?alg=%28R+L%27%29+%28.%2910000000 from failing to load.
Actually, I've gone ahead and bumped it up to 1024. |
I discovered this issue in Twizzle Alpha when inputting a 3BLD reconstruction.
U' U' R' E R U R' E' R U
(U' D') R E' R2' E R (U D)
U' L F L S' L2' S L F' L' U
(U' E') R' E R2 E' R' (U E)
r U R' U' r' R U R U' R'
L' E L U L' E' L2 E2' L' U' L E2' L'
x R' U R' D2 R U' R' D2 (R l)
R' D' R' U' R D2 R' U R D' R
R' (U D') R U' R' D R U R' U' R
(U D) R2 U' R2' U R2 D' R2' U R2 U' R2' U2'
Just lines 1-6 or 7-10 don't cause problems. However, lines 1-10 will cause simultaneous moves to break.
The text was updated successfully, but these errors were encountered: