-
Notifications
You must be signed in to change notification settings - Fork 15
Totally Broken In Safari #3
Comments
This is because Safari doesn't have a bind() function. This is reproducible in my version of Firefox as well. I've fixed this in my fork of twisty.js, I'll send a pull request soon. |
Yeah, that's annoying. I've fixed it as well, with an anonymous function, so I'll use that for now. |
Yeah, that's a solution. Personally, I think it would be nice to have access to bind throughout the source code. My "fix" was to copy the definition of Function.prototype.bind from here: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Function/bind. Your call. |
I think I would prefer not to port language implementations. If Safari gets bind, though, I agree it would be nicer to switch over. |
This isn't a huge deal to me, but how is what I'm proposing any different than the duck punching in RequestAnimationFrame.js? |
It isn't; just more verbose. I think it's fine now (Although maybe it should eventually be separated from the twisty.js source into a utility file - but that's once we have build scripts and stuff). |
The cube remains unresponsive after the first turn. "Solution": Reloading the page.
The text was updated successfully, but these errors were encountered: