Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Totally Broken In Safari #3

Closed
timhabermaas opened this issue Oct 7, 2011 · 6 comments
Closed

Totally Broken In Safari #3

timhabermaas opened this issue Oct 7, 2011 · 6 comments

Comments

@timhabermaas
Copy link

The cube remains unresponsive after the first turn. "Solution": Reloading the page.

@jfly
Copy link
Member

jfly commented Oct 9, 2011

This is because Safari doesn't have a bind() function. This is reproducible in my version of Firefox as well. I've fixed this in my fork of twisty.js, I'll send a pull request soon.

@lgarron
Copy link
Member

lgarron commented Oct 9, 2011

Yeah, that's annoying. I've fixed it as well, with an anonymous function, so I'll use that for now.

lgarron pushed a commit that referenced this issue Oct 9, 2011
@jfly
Copy link
Member

jfly commented Oct 9, 2011

Yeah, that's a solution. Personally, I think it would be nice to have access to bind throughout the source code. My "fix" was to copy the definition of Function.prototype.bind from here: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Function/bind. Your call.

@lgarron
Copy link
Member

lgarron commented Oct 9, 2011

I think I would prefer not to port language implementations. If Safari gets bind, though, I agree it would be nicer to switch over.

@jfly
Copy link
Member

jfly commented Oct 10, 2011

This isn't a huge deal to me, but how is what I'm proposing any different than the duck punching in RequestAnimationFrame.js?

@lgarron
Copy link
Member

lgarron commented Oct 11, 2011

It isn't; just more verbose. I think it's fine now (Although maybe it should eventually be separated from the twisty.js source into a utility file - but that's once we have build scripts and stuff).

@lgarron lgarron closed this as completed Oct 11, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants