Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simplification for expressions upon addition #237

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Add simplification for expressions upon addition #237

merged 3 commits into from
Jul 27, 2023

Conversation

UnsignedByte
Copy link
Collaborator

Moves basic simplification from the ExprIdx smart constructors into the Ctx add function instead.

@UnsignedByte UnsignedByte linked an issue Jul 26, 2023 that may be closed by this pull request
Expressions with operations on concretes should be interned simplified #236
Closed
rachitnigam
rachitnigam reviewed Jul 27, 2023
View reviewed changes
src/ir/comp.rs Outdated Show resolved Hide resolved
rachitnigam
rachitnigam approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@rachitnigam rachitnigam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Merge after resolving them at your discretion.

@UnsignedByte UnsignedByte enabled auto-merge (squash) July 27, 2023 23:50
@UnsignedByte UnsignedByte merged commit 7dc0bc1 into main Jul 27, 2023
2 checks passed
@UnsignedByte UnsignedByte deleted the expr-simplify branch July 27, 2023 23:51
@rachitnigam rachitnigam mentioned this pull request Jul 31, 2023
Merged
@UnsignedByte UnsignedByte mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachitnigam rachitnigam rachitnigam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expressions with operations on concretes should be interned simplified
2 participants
@UnsignedByte @rachitnigam