Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract max-states pass. #255

Merged
merged 10 commits into from
Aug 7, 2023
Merged

Extract max-states pass. #255

merged 10 commits into from
Aug 7, 2023

Conversation

UnsignedByte
Copy link
Collaborator

Fixes #227.

@rachitnigam
Copy link
Member

To make sure this actually works, we should add an option to the fud execution to use the IR-based max states as well: https://github.com/cucapra/filament/blob/main/fud/filament.py#L181

@rachitnigam
Copy link
Member

Can we instead merge this into #256 and replace the max-states in the old flow with this? That PR doesn't have any of the old flow at all.

@UnsignedByte UnsignedByte changed the base branch from main to ir-dev August 5, 2023 02:06
rachitnigam
rachitnigam approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@rachitnigam rachitnigam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on style. Merge at your discretion after addressing them!

This was referenced Aug 7, 2023
Merged
Merged
@UnsignedByte UnsignedByte merged commit 12c60d4 into ir-dev Aug 7, 2023
2 checks passed
@UnsignedByte UnsignedByte deleted the max-states branch August 7, 2023 18:04
@rachitnigam rachitnigam mentioned this pull request Aug 31, 2023
Merged
rachitnigam pushed a commit that referenced this pull request Sep 4, 2023
@UnsignedByte @rachitnigam
Extract max-states pass. (#255)
de80e3e 
* max-states extraction

* formatting

* add dump interface

* add dump interface

* fix interface dumping

* fix bugs in dump interface and pass tests

* style changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachitnigam rachitnigam rachitnigam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract max_states calculation for --dump-interface flag.
2 participants
@UnsignedByte @rachitnigam