Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use separate turnt outputs to reduce clobbering. closes #34 #43

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

anshumanmohan
Copy link
Contributor

A simple PR that helps tidy up our testing a fair bit! As #34 advises, I use turnt's output.extension feature to make bespoke .expect files for each algorithm. A much less stressful testing experience!

@sampsyo
Copy link
Collaborator

sampsyo commented Apr 12, 2023

Excellent! With this, we're getting closer to being able to just do turnt -j test/*.gfa and letting everything run in parallel. There is still the dependency that requires us to do a --save run first on the oracle before doing a "check" run on the saved results, but resolving that will take some careful thinking on the Turnt side. Maybe something very roughly in the ballpark of cucapra/turnt#26.

@anshumanmohan
Copy link
Contributor Author

Ah I didn't fully realize that this was the goal! I have written a little more in cucapra/turnt#26 (comment) but, unless I'm mistaken, my comment there suggests that turnt -j test/*.gfa is not going to be possible in our case, right?

@sampsyo
Copy link
Collaborator

sampsyo commented Apr 12, 2023

Not for now, at least! I think we should be able to get there eventually, but the problem right now is that we need the "oracles" to go first and the "tests" to go second. Maybe Turnt can help us enforce that itself someday.

@anshumanmohan anshumanmohan merged commit bc5be8f into main Apr 12, 2023
@anshumanmohan anshumanmohan deleted the different-turnt-outs branch April 12, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants