Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump miminum cucumber version to 4 #814

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Bump miminum cucumber version to 4 #814

merged 1 commit into from
Jun 20, 2021

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jun 17, 2021

Summary

Bump miminum cucumber version to 4

Details

Update the mimimum required cucumber version to 4 in the gemspec; adjust Appraisals and GitHub Actions configuration.

Motivation and Context

Cucumber 4 is the first version using cucumber-gherkin instead of gherkin as a dependency. Using this as the lowest supported version avoids conflicts between gherkin and cucumber-gherkin when installing all appraisals.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Cucumber 4 is the first version using cucumber-gherkin instead of
gherkin as a dependency. Using this as the lowest supported version
avoids conflicts between gherkin and cucumber-gherkin when installing
all appraisals.
@mvz mvz force-pushed the bump-cucumber-dependency branch from df4f012 to 93b2598 Compare June 20, 2021 11:44
@mvz mvz merged commit 057a7c8 into main Jun 20, 2021
@mvz mvz deleted the bump-cucumber-dependency branch June 20, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant