Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Installation page additions #49

Merged
merged 3 commits into from
Aug 2, 2016
Merged

Conversation

siwood
Copy link
Contributor

@siwood siwood commented Jul 29, 2016

Using installation instructions from the https://cucumber.io/docs#installation pages to add Javascript and Ruby instructions. Adding some structure to the installation part of the SUMMARY.md menu.

@tsundberg
Copy link
Member

tsundberg commented Jul 31, 2016

I looked at this pull request and think it can be merged.

It may be a bit large as it covers both installation and Three Amigos, but it is not a biggi in my book.

@brasmusson
Copy link
Contributor

@tsundberg The Three Amigos is already merged (https://docs.cucumber.io/docs/techniques.html#three-amigos), but habit of @siwood to merge from cucmber:master to the PR branch (instead of rebaseing), will make the list of commits in the PR longer than it should be.

@tsundberg
Copy link
Member

@brasmusson what is your proposal? Merge or not merge?

@siwood
Copy link
Contributor Author

siwood commented Aug 1, 2016

@brasmusson I'm new to git. I will try rebasing next time to avoid the annoying extra commits. Thanks for pointing that out!

@siwood
Copy link
Contributor Author

siwood commented Aug 1, 2016

Ok, I think it's cleaned up.

@tsundberg tsundberg merged commit 9fffb66 into cucumber:master Aug 2, 2016
@siwood siwood deleted the installation branch August 24, 2016 20:51
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants