Add basic windows ci

[cwellm]

Resolves #286

Summary

A CI Workflow was added for Windows.

Details

The CI workflow is bare, i.e. builds only the Cucumber-Cpp core without any test drivers, tests, or examples. To distinguish it better from the Linux build, files have been renamed.

Motivation and Context

We want to be confident that the software works on Windows.

How Has This Been Tested?

CI for Windows

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

• It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
• I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
• I've added tests for my code.
• I have verified whether my change requires changes to the documentation
• My change either requires no documentation change or I've updated the documentation accordingly.
• My branch has been rebased to main, keeping only relevant commits.

[ursfassler]

Hi and thank you for your contribution! It helps the community to have a Windows build.

Please rebase the PR to the latest main branch and only keep the relevant commits in the history. There is a PR template that should automatically ask this (.github/PULL_REQUEST_TEMPLATE.md). Use that and go through the checklist.

I am happy to see the action in action 😏 and the issues addressed I found.

[ursfassler]

@cwellm as the "Windows build" is passing but the "run all / build-windows" is not, I would propose to reduce this PR to the "Windows build". I'd say this is enough address #286 as it shows that it builds on Windows.

[cwellm]

@ursfassler Yes, this is now superfluous.

[ursfassler]

@cwellm well done, that looks good!

One minor thing and then we are ready to merge: the git history has some changes to files that are reverted in later commits (e.g. to the file .github/workflows/run-all.yml, also the windows related files). I'd like to have only relevant changes to the files. This helps to understand the changes in case somebody searches through the history to find an error or so.

You can force push to this branch when you have rewritten the history. Alternatively, I can just "Squash and merge" your changes, but some commits are worth to keep separate (i.e. "Remove unnecessary if condition", maybe " Update README ", for sure "Add concurrency to avoid duplicate flows".

[cwellm]

@ursfassler Thanks! :) I rearranged commits.

[ursfassler]

That looks better!

Unfortunately, there are still some big changes in the first commit (fe7cd9b) that are (partially) reverted later. I am talking about:

• windows section in .github/workflows/run-all.yml
• .github/workflows/test-install-qt5.yml
• adding run-linux.sh by copying run-all.sh

I am a bit picky about those changes because they can give wrong hints when looking through the change history for specific files. E.g. when looking at .github/workflows/run-all.yml, you'll see adding of the windows section while this was never done on main.

Let me know when I can help you or clarify it more.

[ursfassler]

As discussed / rebased together this is good now.

Thanks for your effort!

[aslakhellesoy]

Hi @cwellm,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber