Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello : send you little patch for : #245 Wrong message when runner on a non existing tag on feature #252

Closed
wants to merge 1 commit into from

Conversation

jeremyGoupil
Copy link

#245 Wrong message when runner on a non existing tag on feature

@aslakhellesoy
Copy link
Contributor

This won't work I think. It's common to use tag filters over a collection of features, and end up with e.g. 2 scenarios from 1 feature.

This change would throw an exception for the other features that don't have the tag.

@aslakhellesoy
Copy link
Contributor

I ended up with a slightly different implementation. Thanks for the fix!

@jeremyGoupil
Copy link
Author

Hello,

Ok sorry for this 1/2 fix thanks for your work on this bdd tools.

Jeremy

Envoyé à partir de mon Windows Phone
De : Aslak Hellesøy
Envoyé : 17/03/2012 20:16
À : Jérémy Goupil
Objet : Re: [cucumber-jvm] Hello : send you little patch for : #245
Wrong message when runner on a non existing tag on feature (#252)
I ended up with a slightly different implementation. Thanks for the fix!


Reply to this email directly or view it on GitHub:
#252 (comment)

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants