Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows #549

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Update workflows #549

merged 1 commit into from
Jun 21, 2022

Conversation

luke-hill
Copy link
Contributor

@luke-hill luke-hill commented Jun 21, 2022

Use better words, now we have fixed some issues we can now test a few more areas. Update some support notes

Use better lexicon, now we have fixed some issues we can now test a few more areas
@luke-hill luke-hill enabled auto-merge (squash) June 21, 2022 09:04
@@ -7,18 +7,17 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ '2.5.8', '2.6', '2.7', '3.0', '3.1' ]
gemfile: [ 'rails_5_0', 'rails_5_1', 'rails_5_2', 'rails_6_0', 'rails_6_1', 'rails_7_0' ]
ruby: ['2.5.8', '2.6', '2.7', '3.0', '3.1']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: How would you feel about using YAML lists, like

- '2.5.8'
- '2.6'
- '2.7'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we could. I think this was just the way that GHA was advertised. Everyone I know does it this way.

@luke-hill luke-hill merged commit f835546 into main Jun 21, 2022
@luke-hill luke-hill deleted the updated_workflows branch June 21, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants