Do not apply Before and After Hooks to Test Cases with no Test Steps #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned Also mark the iso-8859-1.feature as wip since the gherkin library (v5.1.0) does not support using iso-8859-1 in feature files.
brasmusson
force-pushed
the
scenarios-no-steps
branch
from
1a51997
to
c69d9f0
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not apply Before and After Hooks to Test Cases with no Test Steps.
Details
Do not apply Before and After Hooks to Test Cases with no Test Steps, so that the executed Test Case really has no Test Steps if the Pickle it was created from had no Pickle Steps.
Motivation and Context
Needed to get the result status Undefined for scenarios with not steps, see cucumber/cucumber-ruby-core#156.
See cucumber/cucumber-ruby-core#144 (comment)
How Has This Been Tested?
The automated test suite has been updated to verify this behavior.
Types of changes
Checklist: