Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a feature describing how I think hooks should work #319

Closed
wants to merge 2 commits into from
Closed

Add a feature describing how I think hooks should work #319

wants to merge 2 commits into from

Conversation

willglynn
Copy link

This feature was requested by /issues/52. It fails against cucumber/master right now, but it clearly demonstrates the issue:

Scenario: Around hooks cover background steps
...
-Event order: around_begin background_step scenario_step around_end
+Event order: background_step around_begin scenario_step around_end

Scenario: All hooks execute in expected order
...
-Event order: around_begin before background_step scenario_step after around_end
+Event order: before background_step around_begin scenario_step after around_end

@willglynn willglynn mentioned this pull request Sep 22, 2012
Closed
@ghost ghost assigned mattwynne Feb 13, 2013
@mattwynne
Copy link
Member

I am looking into this. It's hard, but I think it's possible. It's forcing me to do some good refactoring in any case.

@mattwynne mattwynne mentioned this pull request Mar 5, 2013
Merged
@mattwynne mattwynne mentioned this pull request Mar 21, 2013
Closed
@os97673 os97673 closed this in ab427d0 Nov 14, 2013
@os97673
Copy link
Member

os97673 commented Nov 14, 2013

The test is passing now. So I've added it and closed the PR.

@willglynn willglynn deleted the hook_order_feature branch November 14, 2013 14:06
@tooky
Copy link
Member

tooky commented Nov 15, 2013

\o/

@mattwynne
Copy link
Member

I think that might be the longest-running TDD cycle of my life!

tooky added a commit that referenced this pull request Nov 17, 2013
@tooky
Merge remote-tracking branch 'origin/master' into pending_steps
8f8de91 
* origin/master:
  ReportAdapter should get array of formtters.  Closes #603.
  Autoformat functionality removed from Cucumber 2.0
  Release 1.3.10
  Time for 1.3.10
  sometimes it is more convenient to develop cucumber with cucumber-ruby-core
  Initialize Pretty formatter with output stream when autoformatting
  Update cucumber.yml
  Update cucumber.yml
  It looks like hooks are ok now. Closes #319
  Fixing build failure for some reasons gherkin doesn't like comment after tags
  Attempt to fix build
  Remove @wip tags for fixed scenarios
  Remove wip tag for passing scenario.

Conflicts:
	features/docs/work_in_progress.feature
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mattwynne mattwynne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@willglynn @mattwynne @os97673 @tooky