before updating we need to init the submodule #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcgilchrist
approved these changes
Dec 1, 2022
|
Hi @MarkoSchuetz, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
tmcgilchrist
added a commit
to tmcgilchrist/opam-repository
that referenced
this pull request
Mar 29, 2023
CHANGES: * before updating we need to init the submodule (cucumber/cucumber.ml#37). * Add GitHub Actions CI (@tmcgilchrist cucumber/cucumber.ml#42 cucumber/cucumber.ml#44). * Various fixes for OCaml cucumber (@tmcgilchrist cucumber/cucumber.ml#41). * Improve odoc documentation and add an example. * Update base to v0.15.1 updating OCaml lower bound to 4.10.0. * Update README with a working example. * Fixup linking against libgherkin. * Adapt to the interface changes when updating to gherkin-c v23. * Move git submodule to https://github.com/cucumber/gherkin monorepo. * Fixup cmdliner deprecations and update dune. * Updated README to read a bit better. * Updated Readme to reflect the new build steps. * Removed unnecessary submodule. * Updated dune project information to get things ready for release. * Updated dune files to use autogenerated opam. * Updated test make file to work with new dune build stucture. * Updated files to work with Dune's foreign lib interface. * Added gherkin-c READ ONLY as a submodule. * Updated based on rebase from master. * Added dialect example in the README. * Moved initialization of result code. * Added whitespace for readability. * Added the Dialect module to allow compile time checking of supported dialects of Cucumber * Created a means for indicating feature file dialect. * Removed unneeded flag in dune. * Removed unneeded flag in dune * Added freeing before caml_failwith just to ensure that everything is cleaned up before going back to OCaml runtime. * Refactored long code block into function in gherkin_intf.c. * Refactored long code block into function in gherkin_intf.c * Fixed small memory leak due to TokenScanner not being deleted after it is done being used * Added const qualifier to sFileName to fix cucumber/cucumber.ml#31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just added the command to initialize the submodule.
Motivation & context
Without the prior
initnothing happened upon thesubmodule update